Use totalCost in place of suggestedFeeMutez #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serjonya-trili when I run simulations 
When the transaction is executed the fee is closer to 
Anyways I leave this up to you to merge or not I don't have all the context 👍 |
|
That's a good point @leoparis89 . Looks like when you involve some storage then totalCost becomes closer to the reality, but for bare tez transfers the suggestedFee is more accurate. I think we could try to pick the one that's bigger for now and raise this thing to taquito maintainers |
|
closing it as it was addressed in #304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Task link
Use totalCost in place of suggestedFeeMutez
Types of changes
Put an
xin the boxes that applySteps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.